Clover coverage report - Code Coverage for tapestry release 4.0.3
Coverage timestamp: Fri May 5 2006 21:17:42 CDT
Overview   Package   File
    FRAMES   NO FRAMES  
file stats: LOC: 156   Methods: 4
NCLOC: 83   Classes: 1
 
 Source file Conditionals Statements Methods TOTAL
EnhancedClassValidatorImpl.java 100% 100% 100% 100%
coverage
 1    // Copyright 2004, 2005 The Apache Software Foundation
 2    //
 3    // Licensed under the Apache License, Version 2.0 (the "License");
 4    // you may not use this file except in compliance with the License.
 5    // You may obtain a copy of the License at
 6    //
 7    // http://www.apache.org/licenses/LICENSE-2.0
 8    //
 9    // Unless required by applicable law or agreed to in writing, software
 10    // distributed under the License is distributed on an "AS IS" BASIS,
 11    // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 12    // See the License for the specific language governing permissions and
 13    // limitations under the License.
 14   
 15    package org.apache.tapestry.enhance;
 16   
 17    import java.lang.reflect.Method;
 18    import java.lang.reflect.Modifier;
 19    import java.util.HashMap;
 20    import java.util.HashSet;
 21    import java.util.Iterator;
 22    import java.util.Map;
 23    import java.util.Set;
 24   
 25    import org.apache.hivemind.ErrorLog;
 26    import org.apache.hivemind.Location;
 27    import org.apache.hivemind.service.MethodSignature;
 28    import org.apache.tapestry.spec.IComponentSpecification;
 29   
 30    /**
 31    * Validates that an enhanced class is correct; checks that all inherited abstract methods are, in
 32    * fact, implemented in the class.
 33    *
 34    * @author Howard M. Lewis Ship
 35    * @since 4.0
 36    */
 37    public class EnhancedClassValidatorImpl implements EnhancedClassValidator
 38    {
 39    private ErrorLog _errorLog;
 40   
 41  1179 public void validate(Class baseClass, Class enhancedClass, IComponentSpecification specification)
 42    {
 43    // Set of MethodSignatures for methods that have a non-abstract implementation
 44    // The Set is built working from the deepest subclass up to (and including) java.lang.Object
 45   
 46  1179 Set implementedMethods = new HashSet();
 47    // Key is MethodSignature, value is Method
 48    // Tracks which methods come from interfaces
 49  1179 Map interfaceMethods = new HashMap();
 50   
 51  1179 Location location = specification.getLocation();
 52   
 53  1179 Class current = enhancedClass;
 54   
 55  1179 while (true)
 56    {
 57  5757 addInterfaceMethods(current, interfaceMethods);
 58   
 59    // Inside Eclipse, for abstract classes, getDeclaredMethods() does NOT report methods
 60    // inherited from interfaces. For Sun JDK and abstract classes, getDeclaredMethods()
 61    // DOES report interface methods
 62    // (as if they were declared by the class itself). This code is needlessly complex so
 63    // that the checks work in both
 64    // situations. Basically, I think Eclipse is right and Sun JDK is wrong and we're using
 65    // the interfaceMethods map as a filter to ignore methods that Sun JDK is attributing
 66    // to the class.
 67   
 68  5757 Method[] methods = current.getDeclaredMethods();
 69   
 70  5757 for (int i = 0; i < methods.length; i++)
 71    {
 72  103245 Method m = methods[i];
 73   
 74  103245 MethodSignature s = new MethodSignature(m);
 75   
 76  103245 boolean isAbstract = Modifier.isAbstract(m.getModifiers());
 77   
 78  103245 if (isAbstract)
 79    {
 80  7122 if (interfaceMethods.containsKey(s))
 81  1572 continue;
 82   
 83    // If a superclass defines an abstract method that a subclass implements, then
 84    // all's OK.
 85   
 86  5550 if (implementedMethods.contains(s))
 87  5547 continue;
 88   
 89  3 _errorLog.error(EnhanceMessages.noImplForAbstractMethod(
 90    m,
 91    current,
 92    baseClass,
 93    enhancedClass), location, null);
 94    }
 95   
 96  96126 implementedMethods.add(s);
 97    }
 98   
 99  5757 current = current.getSuperclass();
 100   
 101    // No need to check Object.class; it is concrete and doesn't implement any interfaces,
 102    // or provide any methods
 103    // that might be declared in an interface.
 104   
 105  5757 if (current == null || current == Object.class)
 106  1179 break;
 107    }
 108   
 109  1179 Iterator i = interfaceMethods.entrySet().iterator();
 110  1179 while (i.hasNext())
 111    {
 112  55941 Map.Entry entry = (Map.Entry) i.next();
 113   
 114  55941 MethodSignature sig = (MethodSignature) entry.getKey();
 115   
 116  55941 if (implementedMethods.contains(sig))
 117  55938 continue;
 118   
 119  3 Method method = (Method) entry.getValue();
 120   
 121  3 _errorLog.error(EnhanceMessages.unimplementedInterfaceMethod(
 122    method,
 123    baseClass,
 124    enhancedClass), location, null);
 125    }
 126   
 127    }
 128   
 129  5757 private void addInterfaceMethods(Class current, Map interfaceMethods)
 130    {
 131  5757 Class[] interfaces = current.getInterfaces();
 132   
 133  5757 for (int i = 0; i < interfaces.length; i++)
 134  3699 addMethodsFromInterface(interfaces[i], interfaceMethods);
 135    }
 136   
 137  3699 private void addMethodsFromInterface(Class interfaceClass, Map interfaceMethods)
 138    {
 139  3699 Method[] methods = interfaceClass.getMethods();
 140   
 141  3699 for (int i = 0; i < methods.length; i++)
 142    {
 143  96897 MethodSignature sig = new MethodSignature(methods[i]);
 144   
 145  96897 if (interfaceMethods.containsKey(sig))
 146  40956 continue;
 147   
 148  55941 interfaceMethods.put(sig, methods[i]);
 149    }
 150    }
 151   
 152  123 public void setErrorLog(ErrorLog errorLog)
 153    {
 154  123 _errorLog = errorLog;
 155    }
 156    }
 
CloverReport generated by Clover Code Coverage v1.3.12
Fri May 5 2006 21:21:31 CDT.		   Open Source License registered to the Apache Software Foundation. This license of Clover is provided to support projects of the Apache Software Foundation only.